Hi Thierry,
> I think perhaps what Mark may have meant was something like this:
>
> static inline u32 fsl_pwm_readl(struct fsl_pwm_chip *fpc,
> const void __iomem *addr)
> {
> u32 value = readl(addr);
>
> if (likely(fpc->big_endian))
> value = be32_to_cpu(value);
> else
> value = le32_to_cpu(value);
>
> return value;
> }
>
> static inline void fsl_pwm_writel(struct fsl_pwm_chip *fpc, u32 value,
> const void __iomem *addr)
> {
> if (likely(fpc->big_endian))
> value = cpu_to_be32(value);
> else
> value = cpu_to_le32(value);
>
> writel(value, addr);
> }
>
> That way you call the accessors only once, and do the conversion after
> or before that.
>
Yes, this looks better.
And I have already sent the v7 patches has addressed about this.
--
Xiubo
--
To unsubscribe from this list: send the line "unsubscribe linux-pwm" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
