pwm_samsung_config sets manual update bit via call to pwm_samsung_enable even when the channel is already running. This causes noticable flickers on display if we try to change the backlight value from 0 to MAX, continiously.
So, we remove the call to pwm_samsung_enable from pwm_samsung_config to avoid the flicker and this change doesn't harm normal working since the pwm_bl core already takes care of calling pwm_samsung_enable whenever needed. Signed-off-by: Ajay Kumar <[email protected]> --- drivers/pwm/pwm-samsung.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/pwm/pwm-samsung.c b/drivers/pwm/pwm-samsung.c index d66529a..ba6b650 100644 --- a/drivers/pwm/pwm-samsung.c +++ b/drivers/pwm/pwm-samsung.c @@ -335,9 +335,6 @@ static int pwm_samsung_config(struct pwm_chip *chip, struct pwm_device *pwm, writel(tcnt, our_chip->base + REG_TCNTB(pwm->hwpwm)); writel(tcmp, our_chip->base + REG_TCMPB(pwm->hwpwm)); - if (test_bit(PWMF_ENABLED, &pwm->flags)) - pwm_samsung_enable(chip, pwm); - chan->period_ns = period_ns; chan->tin_ns = tin_ns; chan->duty_ns = duty_ns; -- 1.8.3.2 -- To unsubscribe from this list: send the line "unsubscribe linux-pwm" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
