On Sat, Jan 10, 2015 at 12:34:49AM +0100, Andrew Lunn wrote: > Armada 370/XP devices can 'blink' gpio lines with a configurable on > and off period. This can be modelled as a PWM. > > However, there are only two sets of PWM configuration registers for > all the gpio lines. This driver simply allows a single gpio line per > gpio chip of 32 lines to be used as a PWM. Attempts to use more return > EBUSY. > > Due to the interleaving of registers it is not simple to separate the > PWM driver from the gpio driver. Thus the gpio driver has been > extended with a PWM driver. > > Signed-off-by: Andrew Lunn <[email protected]> > --- > drivers/gpio/Kconfig | 5 ++ > drivers/gpio/Makefile | 1 + > drivers/gpio/gpio-mvebu-pwm.c | 202 > ++++++++++++++++++++++++++++++++++++++++++ > drivers/gpio/gpio-mvebu.c | 37 +++----- > drivers/gpio/gpio-mvebu.h | 79 +++++++++++++++++ > 5 files changed, 299 insertions(+), 25 deletions(-) > create mode 100644 drivers/gpio/gpio-mvebu-pwm.c > create mode 100644 drivers/gpio/gpio-mvebu.h
FWIW, I think this could easily just be all in the gpio-mvebu.c driver, no need to split it up. Thierry
pgpepdQqGQWaZ.pgp
Description: PGP signature
