Thilo's fix for mkpv.c appears in a different form in
raid_io.c. I think the code would be more consistient
and portable if the following lines were removed from raid_io.c.
raid_io.c:21:#ifndef BLKGETSIZE
raid_io.c:22:#define BLKGETSIZE _IO(0x12, 96) /* Return device size. */
raid_io.c:23:#endif
Both raid_io.c and mkpv.c use BLKGETSIZE.
Both should get BLKGETSIZE from <sys/mount.h>. Some
distributions (SuSE 5.3) don't have glibc header files.
I guess for those systems you have two choices:
1. Put the #ifndef BLKGETSIZE block in _BOTH_ mkpv.c and raid_io.c
or
2. #include <linux/fs.h> in mkpv.c like Thilo did.
Thanks for some great RAID code.
eric
Thilo Herrmann wrote:
>
> >> mkpv.c: BLKGETSIZE undefined.
> >> #include <linux/fs.h>
>
> >i guess your system is not glibc based. Including Linux kernel headers
> is
> >now considered pretty unsafe.
>
> I forgot that piece of system info. You�re right, it uses libc5. Seems
> that BLKGETSIZE is not defined in <sys/mount.h> with libc5 (this might
> need some kind of workaround for the beta/final raidtools).
>
--
__________________________________________________________________
Eric T. Whiting AMI Semiconductors
(208) 234-6717 2300 Buckskin Road
(208) 234-6795 (fax) Pocatello,ID 83201
[EMAIL PROTECTED]
