On 1/7/2015 6:32 PM, Weiny, Ira wrote:
>On 11/27/2014 3:51 PM, Sagi Grimberg wrote:
> >We're already short on bits in device_cap_flags
>
>no shortage @ the kernel... we can add more 32 bits if/when we need it
Why is there a gap in the bits?

enum ib_device_cap_flags {
...
         IB_DEVICE_MEM_WINDOW_TYPE_2B    = (1<<24),
         IB_DEVICE_MANAGED_FLOW_STEERING = (1<<29),
...
};

25-28 are not used?  Is there some legacy software out there which uses these?

sort of... the verbs RSS design which wasn't accepted upstream uses bits 25/26/27 and Mellanox Core-Direct (whose verbs model called "Cross-Channel") which wasn't submitted upstream yet uses bit 28. Since in the kernel we can trivially use 64 bits, I would opt to keep these entries free for now.

Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to