On 1/14/2015 8:38 AM, Doug Ledford wrote:
The usage of IPOIB_MCAST_RUN as a flag is inconsistent.  In some places
it is used to mean "our device is administratively allowed to send
multicast joins/leaves/packets" [...]
what? please tell which of these upstream hits (prior to any fix) has this semantics?

# git grep -n IPOIB_MCAST_RUN drivers/infiniband/ulp/ipoib
drivers/infiniband/ulp/ipoib/ipoib.h:90: IPOIB_MCAST_RUN           = 6,
drivers/infiniband/ulp/ipoib/ipoib_multicast.c:434: if (test_bit(IPOIB_MCAST_RUN, &priv->flags)) drivers/infiniband/ulp/ipoib/ipoib_multicast.c:466: if (status && test_bit(IPOIB_MCAST_RUN, &priv->flags)) drivers/infiniband/ulp/ipoib/ipoib_multicast.c:536: if (test_bit(IPOIB_MCAST_RUN, &priv->flags)) drivers/infiniband/ulp/ipoib/ipoib_multicast.c:550: if (!test_bit(IPOIB_MCAST_RUN, &priv->flags)) drivers/infiniband/ulp/ipoib/ipoib_multicast.c:576: if (test_bit(IPOIB_MCAST_RUN, &priv->flags)) drivers/infiniband/ulp/ipoib/ipoib_multicast.c:634: clear_bit(IPOIB_MCAST_RUN, &priv->flags); drivers/infiniband/ulp/ipoib/ipoib_multicast.c:644: if (!test_and_set_bit(IPOIB_MCAST_RUN, &priv->flags)) drivers/infiniband/ulp/ipoib/ipoib_multicast.c:658: clear_bit(IPOIB_MCAST_RUN, &priv->flags); drivers/infiniband/ulp/ipoib/ipoib_multicast.c:728: if (!test_and_set_bit(IPOIB_MCAST_RUN, &priv->flags))

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to