On Thu, Jun 11, 2015 at 8:53 PM, Jason Gunthorpe <[email protected]> wrote: > On Thu, Jun 11, 2015 at 04:35:19PM +0300, Or Gerlitz wrote: >> Jason had another comment calling for re-thinking / questioning the >> need for a dedicated uverbs_ex_cmd_mask in the IB device. This goes >> beyond the scope of this specific series. > > How is properly setting up the new verbs you added beyond the scope of > this series?
We didn't add the extended query device uverb call, it was the ODP series doing so 1-2 upstream releases ago. > It is a trivial change to move this: > + ibdev->ib_dev.uverbs_ex_cmd_mask |= > + (1ull << IB_USER_VERBS_EX_CMD_QUERY_DEVICE) | > + (1ull << IB_USER_VERBS_EX_CMD_CREATE_CQ); > > Into the right core function so it is enabled for all drivers. I'm really not sure, and if the consensus on the list would be doing this is the right thing, lets do it in incremental patch around rc1 or even on top of this series if there's time before the pull request or if there's rc8 Doug - makes sense? > That isn't re thinking at all, that is how the extension mechanism was > always intended to work. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
