On 07/15/2015 05:12 AM, Thomas Gleixner wrote:
On Wed, 15 Jul 2015, Christoph Hellwig wrote:
Many years ago we decided to move setting of IRQ to core affnities to
userspace with the irqbalance daemon.
These days we have systems with lots of MSI-X vector, and we have
hardware and subsystem support for per-CPU I/O queues in the block
layer, the RDMA subsystem and probably the network stack (I'm not too
familar with the recent developments there). It would really help the
out of the box performance and experience if we could allow such
subsystems to bind interrupt vectors to the node that the queue is
configured on.
I'd like to discuss if the rationale for moving the IRQ affinity setting
fully to userspace are still correct in todays world any any pitfalls
we'll have to learn from in irqbalanced and the old in-kernel affinity
code.
I think setting an initial affinity is not going to create the horror
of the old in-kernel irq balancer again. It still could be changed
from user space and does not try to be smart by moving interrupts
around in circles all the time.
Thanks Thomas for your feedback. But no matter whether IRQ balancing
happens in user space or in the kernel, the following issues need to be
addressed and have not yet been addressed today:
* irqbalanced is not aware of the relationship between MSI-X vectors.
If e.g. two kernel drivers each allocate 24 MSI-X vectors for the
PCIe interfaces they control irqbalanced could e.g. decide to
associate all MSI-X vectors for the first PCIe interface with a first
set of CPUs and the MSI-X vectors of the second PCIe interface with a
second set of CPUs. This will result in suboptimal performance if
these two PCIe interfaces are used alternatingly instead of
simultaneously.
* With blk-mq and scsi-mq optimal performance can only be achieved if
the relationship between MSI-X vector and NUMA node does not change
over time. This is necessary to allow a blk-mq/scsi-mq driver to
ensure that interrupts are processed on the same NUMA node as the
node on which the data structures for a communication channel have
been allocated. However, today there is no API that allows
blk-mq/scsi-mq drivers and irqbalanced to exchange information
about the relationship between MSI-X vector ranges and NUMA nodes.
The only approach I know of that works today to define IRQ affinity
for blk-mq/scsi-mq drivers is to disable irqbalanced and to run a
custom script that defines IRQ affinity (see e.g. the
spread-mlx4-ib-interrupts attachment of
http://thread.gmane.org/gmane.linux.kernel.device-mapper.devel/21312/focus=98409).
Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
