On Mon, Nov 09, 2015 at 08:48:36AM +0200, Haggai Eran wrote:
> On 08/11/2015 17:04, Matan Barak wrote:
> >> @@ -704,6 +719,10 @@ static ssize_t ib_uverbs_write(struct file *filp,
> >> const char __user *buf,
> >> > }
> >> >
> >> > command = hdr.command & IB_USER_VERBS_CMD_COMMAND_MASK;
> >> > + if (verify_command_mask(ib_dev, command)) {
> >> > + ret = -EINVAL;
> > Why did you replace ENOSYS with EINVAL?
>
> I think ENOSYS is meant only to represent a system call number that
> isn't supported. There was a change in checkpatch that now warns about
> it [1]. I'm not sure the intention was to fix existing uses though.
Within verbs we should have two kinds of return - not supported
request, and supported request with invalid parameters.
Maybe use EOPNOTSUPP ?
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
