On Sun, Nov 22, 2015 at 12:15 PM, Christoph Hellwig <[email protected]> wrote: > Hi Matan, > > IB_CQ_FLAGS_TIMESTAMP_COMPLETION is _only_ used in the uverbs interface. >
Currently this is used only for uverbs interface. The reason for that is that we've only pushed completion timestamping for user-space support. However, there's no reason not to add support for completion timestamping for ULPs. Therefore, the same flag could be relevant for ULPs as well. > But other than that userspace ABIs really must go to the UAPI headers, > otherwise they will be broken sooner or later. RDMA is an unfortunate > oddball under the kernel subsystems that's been ignoring the rule for So do you imply ib_verbs.h should include ib_user_verbs.h? > now. Please ensure at least new interfaces follow this principle, and > old code will need to be fixed up as well. Ok, I'll follow this principle for new features. Matan -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
