On Sun, Nov 22, 2015 at 05:53:43AM -0800, Christoph Hellwig wrote:
> To me this sounds like another argument to just allocate one FR
> per request and don't allow non-contiguous SGLs.
> 
> Also note that 4.4-rc  prefer_fr=y register_always=n
> !register_always still blows up badly with XFS and ext4 due to
> data integrity errors.

A little instrumention revealed that the corrupted buffers are
correlated to the 'gap' case in ib_sg_to_pages.  I haven't found
anything obvious yet, but ading this line to srp_slave_configure:

        blk_queue_virt_boundary(q, target->srp_host->srp_dev->mr_page_size - 1);

and thus avoiding the gap cases makes xfstests pass fine for me, with or
without the register_always parameter.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to