On 12/8/2015 7:26 PM, Hefty, Sean wrote: >>> + * Determine the default pkey for parsing address file as well. >>> + * order of preference: first full-member non-management pkey, >>> + * 0xffff, first pkey. >>> + */ >> >> This really should just be the 0 index pkey, which exactly matches how >> IPoIB determines the default pkey, which is what matters when talking >> rdmacm.. > > Ibacm currently hard-codes the 'default' pkey to 0xffff for ibacm <-> ibacm > communication. > If there's no disagreement to switching to pkey[0], I'm fine with that.
There's no IBA requirement that 0xffff pkey is always in index 0. It's only a requirement on device bootup with non volatile storage per C10-123. Furthermore, there's no requirement that 0xffff pkey is present in the table. It may be that there's only 0x7fff pkey. > I did not realize that ipoib uses this same default. I think this is a problem in limiting partition use and should be changed. Rather than assuming index 0, pkey table should be searched for this pkey. -- Hal -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
