On Mon, 14 Dec 2015, Weiny, Ira wrote: > > How about > >=20 > > ipoib_check_and_add_mcast_sendonly() > > Better.
Fixup patch: Subject: ipoib: Fix up naming of ipoib_check_and_add_mcast_sendonly Signed-off-by: Christoph Lameter <[email protected]> Index: linux/drivers/infiniband/ulp/ipoib/ipoib.h =================================================================== --- linux.orig/drivers/infiniband/ulp/ipoib/ipoib.h +++ linux/drivers/infiniband/ulp/ipoib/ipoib.h @@ -549,7 +549,7 @@ void ipoib_path_iter_read(struct ipoib_p int ipoib_mcast_attach(struct net_device *dev, u16 mlid, union ib_gid *mgid, int set_qkey); void ipoib_mcast_remove_list(struct net_device *dev, struct list_head *remove_list); -void ipoib_check_mcast_sendonly(struct ipoib_dev_priv *priv, u8 *mgid, +void ipoib_check_and_add_mcast_sendonly(struct ipoib_dev_priv *priv, u8 *mgid, struct list_head *remove_list); int ipoib_init_qp(struct net_device *dev); Index: linux/drivers/infiniband/ulp/ipoib/ipoib_main.c =================================================================== --- linux.orig/drivers/infiniband/ulp/ipoib/ipoib_main.c +++ linux/drivers/infiniband/ulp/ipoib/ipoib_main.c @@ -1179,7 +1179,7 @@ static void __ipoib_reap_neigh(struct ip /* was the neigh idle for two GC periods */ if (time_after(neigh_obsolete, neigh->alive)) { - ipoib_check_mcast_sendonly(priv, neigh->daddr + 4, &remove_list); + ipoib_check_and_add_mcast_sendonly(priv, neigh->daddr + 4, &remove_list); rcu_assign_pointer(*np, rcu_dereference_protected(neigh->hnext, Index: linux/drivers/infiniband/ulp/ipoib/ipoib_multicast.c =================================================================== --- linux.orig/drivers/infiniband/ulp/ipoib/ipoib_multicast.c +++ linux/drivers/infiniband/ulp/ipoib/ipoib_multicast.c @@ -708,7 +708,7 @@ static int ipoib_mcast_leave(struct net_ * Check if the multicast group is sendonly. If so remove it from the maps * and add to the remove list */ -void ipoib_check_mcast_sendonly(struct ipoib_dev_priv *priv, u8 *mgid, +void ipoib_check_and_add_mcast_sendonly(struct ipoib_dev_priv *priv, u8 *mgid, struct list_head *remove_list) { /* Is this multicast ? */ -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
