On Thu, 17 Dec 2015, Hal Rosenstock wrote:
> > + if (cpi.capability_mask && IB_PMA_CLASS_CAP_EXT_WIDTH) {
> > + /* We have extended counters */
> > +
> > + if (cpi.capability_mask && IB_PMA_CLASS_CAP_EXT_WIDTH_NOIETF)
> > + /* But not the IETF ones */
> > + return &pma_group_noietf;
>
> These 2 capability bits are mutually exclusive so I think it should be:
>
> if (cpi.capability_mask && IB_PMA_CLASS_CAP_EXT_WIDTH) {
> /* We have extended counters */
> return &pma_group_ext;
> }
>
> if (cpi.capability_mask && IB_PMA_CLASS_CAP_EXT_WIDTH_NOIETF)
> /* But not the IETF ones */
> return &pma_group_noietf;
This case would then use the 64 bit counters despite of the
IB_PMA_CLASS_CAP_EXT_WIDTH not being set.
> }
>
> return &pma_group;
>
> > +
The tables contain all the counters each. So we would need another table
of counters that has the ietf counters but not the 64 bit extended ones?
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
