Sasha,
On Thu, Oct 1, 2009 at 3:25 PM, Sasha Khapyorsky <[email protected]> wrote:
>
> Fix some obvious (not all) compile warnings generated when
> -Wsign-compare flag is used.
>
> Signed-off-by: Sasha Khapyorsky <[email protected]>
> ---
<snip...>
> diff --git a/opensm/opensm/osm_mcast_mgr.c b/opensm/opensm/osm_mcast_mgr.c
> index 6f51404..aaab91a 100644
> --- a/opensm/opensm/osm_mcast_mgr.c
> +++ b/opensm/opensm/osm_mcast_mgr.c
> @@ -1004,7 +1004,7 @@ static int mcast_mgr_set_mftables(osm_sm_t * sm)
> osm_switch_t *p_sw;
> osm_mcast_tbl_t *p_tbl;
> int block_notdone, ret = 0;
> - int16_t block_num, max_block = -1;
> + uint16_t block_num, max_block = -1;
Doesn't this change break the loop which uses block_num/max_block like:
for (block_num = 0; block_num <= max_block; block_num++) {
...
so should a max_block check be inserted before that loop ?
-- Hal
> p_sw = (osm_switch_t *) cl_qmap_head(p_sw_tbl);
> while (p_sw != (osm_switch_t *) cl_qmap_end(p_sw_tbl)) {
<snip...>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
