On Wed, Oct 14, 2009 at 10:34 AM, Sasha Khapyorsky <[email protected]> wrote:
> On 09:33 Wed 14 Oct     , Hal Rosenstock wrote:
>> On Wed, Oct 14, 2009 at 9:29 AM, Sasha Khapyorsky <[email protected]> 
>> wrote:
>> > On 09:14 Wed 14 Oct     , Hal Rosenstock wrote:
>> >>
>> >> Also, combine malloc/memset into calloc
>> >
>> > Any special reason for malloc/calloc change?
>>
>> It's a little more concise and efficient to calloc rather than
>> malloc/memset.
>
> Why do you think so? Normally calloc() is malloc() + memset() - you
> just get extra call and extra check.
>
>> Any reason not to do this ?
>
> Above.
>
> calloc() can be nicer in some cases and pretty common, feel free to use
> it when appropriate. But I don't think that we need to make a global
> malloc() -> calloc() conversion without any good reason.

The generated code is slightly smaller.

What do you consider appropriate/good reason ?

-- Hal

> Sasha
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to