> > > - wait_for_completion(&target->done); > > > > How do you avoid leaking connection on module unload etc? Don't we have > > to wait for the disconnect to finish somewhere? > > > > - R. > > > Are you talking about cm_id? > I think that we wait because we want to reuse cq/qp associate with the > connection. > On module unload, we destroy cm_id, cq, qp altogether.
OK, I think I understand this piece locally (although if you delete the wait_for_completion() it would probably make more sense to delete the init_completion() just before it as well). However is it really a correct to reuse a cm_id that is in state timewait to initiate a new connection? That seems pretty fragile to me. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
