On 15:43 Thu 15 Oct , Hal Rosenstock wrote: > On Thu, Oct 15, 2009 at 3:26 PM, Sasha Khapyorsky <[email protected]> wrote: > > On 09:36 Thu 15 Oct , Hal Rosenstock wrote: > >> > >> Signed-off-by: Hal Rosenstock <[email protected]> > >> --- > >> diff --git a/opensm/opensm/osm_ucast_cache.c > >> b/opensm/opensm/osm_ucast_cache.c > >> index 31a5333..8db9df2 100644 > >> --- a/opensm/opensm/osm_ucast_cache.c > >> +++ b/opensm/opensm/osm_ucast_cache.c > >> @@ -876,7 +876,7 @@ void osm_ucast_cache_add_link(osm_ucast_mgr_t * p_mgr, > >> if (osm_node_get_type(p_node_1) != IB_NODE_TYPE_SWITCH && > >> osm_node_get_type(p_node_2) != IB_NODE_TYPE_SWITCH) { > >> OSM_LOG(p_mgr->p_log, OSM_LOG_INFO, > >> - "Dropping CA-2-CA link - cache invalid\n"); > >> + "Dropping CA/RTR-2-CA/RTR link - cache invalid\n"); > > > > IMHO it looks more confusing after the change. > > It's more accurate and consistent;
This is a log message, not a spec, and 'CA/RTR-2-CA/RTR' as single link abbreviation looks strange. If you want to make things clearer find a clear single name or abbreviation for CA/RTR. > There's another log message which > says "CA/RTR-2-CA/RTR" rather than "CA-2-CA". Likely I missed this in those big patch. Would be better to rename back IMHO. Sasha -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
