>This fixes one subtle bug, where a return of 0 from the kernel will >result in a success report from the library, and fixes a terrible >API in the process. Use errno, or return the code, or both. >Not half and half.. > >It is easier to return errno than to fixup the cases that don't, >so lets stick with that. > >Codes should have been be positive for alignment with POSIX, but >it is much too late for that.. > >Signed-off-by: Jason Gunthorpe <[email protected]> >--- > src/cm.c | 30 +++++++++++++++--------------- > 1 files changed, 15 insertions(+), 15 deletions(-) > >librdmacm has the same basic flaw too.
Thanks - I'll fixup librdmacm the same way. Is there a reason that you used -1*errno, rather than just -errno? - Sean -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
