>On a different issue... in the rdma_join_multicast code
>shouldn't  if (pthread_cond_init(&id_priv->cond, NULL)) be if
>(pthread_cond_init(&mc->cond, NULL))

err... yeah, I'll fix this.  Thanks

>The id_priv->cond is already initialized when this is called.
>Hope I'm wrong, otherwise it's a bit scary to think we are using these calls
>(rdma_leave_multicast uses this cond).

It may not be too bad.  The mc structure is cleared, and if pthread_cond_init
simply sets some values to 0, things may work okay.  rdma_destroy_id has a check
before waiting on id_priv->cond, and since calling rdma_join_multicast and
rdma_destroy_id simultaneously is disallowed, if we wait on id_priv->cond it
should still be signaled.

This should be fixed though.  I'll try to push out a new release with these
changes this week.

- Sean

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to