On 16:44 Fri 30 Oct , Hal Rosenstock wrote:
> >
> > diff --git a/opensm/opensm/osm_mcast_tbl.c b/opensm/opensm/osm_mcast_tbl.c
> > index 0a45904..a599e56 100644
> > --- a/opensm/opensm/osm_mcast_tbl.c
> > +++ b/opensm/opensm/osm_mcast_tbl.c
> > @@ -245,8 +245,8 @@ void osm_mcast_tbl_clear_mlid(IN osm_mcast_tbl_t *
> > p_tbl, IN uint16_t mlid_ho)
> > CL_ASSERT(p_tbl);
> > CL_ASSERT(mlid_ho >= IB_LID_MCAST_START_HO);
> >
> > - if (p_tbl->p_mask_tbl && mlid_ho <= p_tbl->max_mlid_ho) {
> > - mlid_offset = mlid_ho - IB_LID_MCAST_START_HO;
> > + mlid_offset = mlid_ho - IB_LID_MCAST_START_HO;
> > + if (p_tbl->p_mask_tbl && mlid_offset < p_tbl->mft_depth) {
> > for (i = 0; i <= p_tbl->max_position; i++)
> > (*p_tbl->p_mask_tbl)[mlid_offset][i] = 0;
> > }
> >
> > Does it make sense?
>
> Yes, that fixes the removal issue.
>
> Tested-by: Hal Rosenstock <[email protected]>
Thanks I will apply the patch.
Yet another (likely even more efficient) approach would be memset()ing
MFTs in realloc function above requested mlid_offset, then we will be
able to remove osm_mcast_tbl_clear_mlid() completely.
Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
