> +    /* Detect if this device is a virtual function */
 > +    switch (id->device) {
 > +    case 0x6341:
 > +    case 0x634b:
 > +    case 0x6733:
 > +    case 0x673d:
 > +    case 0x6369:
 > +    case 0x6751:
 > +    case 0x6765:

This isn't be maintainable or sane.  How about using driver_data in the
PCI device table?

 > +#ifdef CONFIG_PCI_IOV
 > +            if (sr_iov) {

Can we avoid a lot of these ifdefs by just doing

#else
#define sr_iov  0
#endif /* CONFIG_PCI_IOV */

at the beginning and letting the IOV code be optimized away?

 - R.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to