On 12/16/09, Yevgeny Kliteynik <[email protected]> wrote: > On 15/Dec/09 18:12, Hal Rosenstock wrote: >> On Fri, Nov 27, 2009 at 8:45 AM, Line Holen<[email protected]> wrote: >>> Added transaction ID to a message >>> >>> Signed-off-by: Line Holen<[email protected]> >>> >>> --- >>> >>> diff --git a/opensm/opensm/osm_vl15intf.c b/opensm/opensm/osm_vl15intf.c >>> index c380a55..cc3ff33 100644 >>> --- a/opensm/opensm/osm_vl15intf.c >>> +++ b/opensm/opensm/osm_vl15intf.c >>> @@ -1,4 +1,5 @@ >>> /* >>> + * Copyright (c) 2009 Sun Microsystems, Inc. All rights reserved. >>> * Copyright (c) 2004-2009 Voltaire, Inc. All rights reserved. >>> * Copyright (c) 2002-2006 Mellanox Technologies LTD. All rights >>> reserved. >>> * Copyright (c) 1996-2003 Intel Corporation. All rights reserved. >>> @@ -91,7 +92,8 @@ static void vl15_send_mad(osm_vl15_t * p_vl, osm_madw_t >>> * p_madw) >>> } >>> >>> OSM_LOG(p_vl->p_log, OSM_LOG_ERROR, "ERR 3E03: " >>> - "MAD send failed (%s)\n", ib_get_err_str(status)); >>> + "MAD send failed (%s), TID 0x%" PRIx64 "\n", >>> + ib_get_err_str(status), >>> cl_ntoh64(p_madw->p_mad->trans_id)); >> >> I don't think it's safe to touch the MAD once it's been returned to >> the pool. So either this change needs to be reverted or the >> transaction ID (and any other info to be printed on error) saved and >> logged on error. > > I'm actually seeing OSM crashing on this line > pretty reliably. For now I've issued a revert > patch.
I'll shortly send an alternative patch which preserves Line's tid printing in vl15_send_mad. -- Hal > > -- Yevgeny > >> -- Hal >> >>> >>> /* >>> The MAD was never successfully sent, so >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in >>> the body of a message to [email protected] >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in >> the body of a message to [email protected] >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
