>@@ -2941,21 +2960,24 @@ static void ib_mad_init_device(struct ib_device
This is at the top of ib_mad_init_device():
if (rdma_node_get_transport(device->node_type) != RDMA_TRANSPORT_IB)
return;
...
>*device)
> return;
>
> error_agent:
>- if (ib_mad_port_close(device, i))
>- printk(KERN_ERR PFX "Couldn't close %s port %d\n",
>- device->name, i);
>+ if (rdma_node_get_transport(device->node_type) == RDMA_TRANSPORT_IB)
... so this if statement will always be true. Using rdma_port_link_layer()
doesn't seem quite right for QP 1 support, so I'm not sure that you want this
check at all.
>+ if (ib_mad_port_close(device, i))
>+ printk(KERN_ERR PFX "Couldn't close %s port %d\n",
>+ device->name, i);
>
> error:
> i--;
>
> while (i >= start) {
>- if (ib_agent_port_close(device, i))
>- printk(KERN_ERR PFX "Couldn't close %s port %d "
>- "for agents\n",
>- device->name, i);
>- if (ib_mad_port_close(device, i))
>- printk(KERN_ERR PFX "Couldn't close %s port %d\n",
>- device->name, i);
>+ if (rdma_node_get_transport(device->node_type) ==
>RDMA_TRANSPORT_IB) {
Same here.
>+ if (ib_agent_port_close(device, i))
>+ printk(KERN_ERR PFX "Couldn't close %s port %d "
>+ "for agents\n",
>+ device->name, i);
>+ if (ib_mad_port_close(device, i))
>+ printk(KERN_ERR PFX "Couldn't close %s port
%d\n",
>+ device->name, i);
>+ }
> i--;
> }
> }
>@@ -2972,13 +2994,15 @@ static void ib_mad_remove_device(struct ib_device
>*device)
> cur_port = 1;
> }
> for (i = 0; i < num_ports; i++, cur_port++) {
>- if (ib_agent_port_close(device, cur_port))
>- printk(KERN_ERR PFX "Couldn't close %s port %d "
>- "for agents\n",
>- device->name, cur_port);
>- if (ib_mad_port_close(device, cur_port))
>- printk(KERN_ERR PFX "Couldn't close %s port %d\n",
>- device->name, cur_port);
>+ if (rdma_node_get_transport(device->node_type) ==
>RDMA_TRANSPORT_IB) {
It would be more efficient to move this check outside of the for loop, similar
to the check in ib_mad_init_device().
>+ if (ib_agent_port_close(device, cur_port))
>+ printk(KERN_ERR PFX "Couldn't close %s port %d "
>+ "for agents\n",
>+ device->name, cur_port);
>+ if (ib_mad_port_close(device, cur_port))
>+ printk(KERN_ERR PFX "Couldn't close %s port
%d\n",
>+ device->name, cur_port);
>+ }
> }
> }
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
