I'm not thrilled about this patch. > +module_param_named(set_4k_mtu, mlx4_ib_set_4k_mtu, int, 0444); > +MODULE_PARM_DESC(set_4k_mtu, "attempt to set 4K MTU to all ConnectX ports");
What does "attempt to set 4K MTU" mean? Try to set the MTU cap to 4K? What happens if it fails? Is there any reason not to just let the MTU cap be 4K all time? Having this be a module parameter really seems like a bad idea for the future.... > + if (mlx4_ib_set_4k_mtu) > + ((__be32 *) mailbox->buf)[0] |= cpu_to_be32((1 << 22) | > + (1 << 21) | > + (5 << 12) | > + (2 << 4)); Is there any way for this to write this with fewer unexplained magic numbers? - R. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
