Sean Hefty wrote:
It appears that the dev_type is ARPHDR_ETHER. Is this correct, or should a
different dev_type be used? Maybe some sort of mapping from ARPHDR_* dev_type
to an RDMA device type is needed in ib_addr, possibly in rdma_copy_addr().
Looking at a struct net_device, how do we know what kind of RDMA device we have
if the ARPHDR dev_type isn't sufficient?
For the call to rdma_addr_get_sgid(), maybe the name or purpose of that call
needs to be changed, with a second call being added. What cma_acquire_dev()
wants is a local device address so that it can match the net_device up with the
ib_device. Perhaps there's a cleaner way to do this than calling
rdma_addr_get_sgid() from cma_acquire_dev().
Along these same lines, why can't the 'sgid' be incorporated into the
src_dev_addr, similar to what is done for iwarp devices? I don't really
understand the function rocee_mac_to_ll(), and maybe it's just the name. I'm
assuming that 'll' stands for link-layer, correct? Since the MAC address is a
link-layer address, what layer is the GID
I believe that all Sean's comments apply to the mainline submission of
the IBoE patches, so lets see how they are addressed throughout the
review process.
Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
