That will be fine. Thanks Faisal
>-----Original Message----- >From: Roland Dreier [mailto:[email protected]] >Sent: Friday, February 19, 2010 3:18 PM >To: Latif, Faisal >Cc: [email protected] >Subject: Re: [PATCH] rdma/nes: set assume_alligned_header bit > > > nesqp->nesqp_context->ird_ord_sizes = >cpu_to_le32(NES_QPCONTEXT_ORDIRD_ALSMM | > > ((((u32)nesadapter->max_irrq_wr) << > > NES_QPCONTEXT_ORDIRD_IRDSIZE_SHIFT) & >NES_QPCONTEXT_ORDIRD_IRDSIZE_MASK)); > > + nesqp->nesqp_context->ird_ord_sizes |= >cpu_to_le32(NES_QPCONTEXT_ORDIRD_AAH); > >I think I would just combine this into the existing assignment (which >could also probably be formatted better but I'm not worrying about >this), and write the whole thing as: > > nesqp->nesqp_context->ird_ord_sizes = >cpu_to_le32(NES_QPCONTEXT_ORDIRD_ALSMM | > NES_QPCONTEXT_ORDIRD_AAH | > ((((u32)nesadapter->max_irrq_wr) << > NES_QPCONTEXT_ORDIRD_IRDSIZE_SHIFT) & >NES_QPCONTEXT_ORDIRD_IRDSIZE_MASK)); > >-- >Roland Dreier <[email protected]> >For corporate legal information go to: >http://www.cisco.com/web/about/doing_business/legal/cri/index.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
