On Thu, Feb 25, 2010 at 09:49:15AM +0100, Jiri Pirko wrote: > Thu, Feb 25, 2010 at 09:00:07AM CET, [email protected] wrote: > >Jiri Pirko wrote: > >> +++ b/drivers/infiniband/ulp/ipoib/ipoib_multicast.c > >> @@ -767,11 +767,8 @@ void ipoib_mcast_dev_flush(struct net_device *dev) > >> -static int ipoib_mcast_addr_is_valid(const u8 *addr, unsigned int addrlen, > >> - const u8 *broadcast) > >> +static int ipoib_mcast_addr_is_valid(const u8 *addr, const u8 *broadcast) > >> { > >> - if (addrlen != INFINIBAND_ALEN) > >> - return 0; > > > >This check was added by commit 5e47596b "IPoIB: Check multicast address > >format", may I ask what is the reason for removing it now? > > Yes, at this very moment the check is not needless but it will be in a brief > future. dev_mc_add will look very similar like dev_unicast_add. But ok. Here's > patch adding the check in dev_mc_add right now to correct this state. Thanks > Or.
Is this enough? The problem this statement is trying to solve had to do with bonding creating multicast addresess for ethernet rather than infiniband in some cases. This happens because bonding makes a device that switches from ethernet to infiniband during its lifetime. I'm not quite sure what kind of life cycle those addresses go through, but if they somehow stay on the mc_list then ipoib_mcast_addr_is_valid will still need to have the check. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
