On Thu, Mar 25, 2010 at 12:05:33PM -0700, Sean Hefty wrote: > + case AF_IB: > + ((struct sockaddr_ib *) addr)->sib_sid = > + cpu_to_be64(((u64) id_priv->id.ps << 16) + ntohs(port)); > + break; > + }
Could you elaborate a bit on how you are mixing the port space and the SID? IMHO, after thinking about it for a bit, I would prefer to see the port space be unused from a user-space perspective when used with AF_IB. If a ps is needed in the kernel then it should pick the ps based on the SID prefix that user space provided.. I guess prior to adding the mask bits this wouldn't have made sense, but now that they are in it seems like the way to go. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
