> Do you propose to use IB_ATOMIC_GLOB instead of IB_ATOMIC_HCA while setting > atomic capability in the code below? > > props->atomic_cap = dev->dev->caps.flags & > MLX4_DEV_CAP_FLAG_ATOMIC ? > IB_ATOMIC_HCA : IB_ATOMIC_NONE; > > Or add IB_MASKED_ATOMIC to ib_atomic_cap enum and use this one > instead of IB_ATOMIC_HCA? > > All this, of course, comes to replace setting > IB_DEVICE_MASKED_ATOMIC for device capability.
Sorry, missed this reply first time around I guess. Anyway, no I don't think we should use ATOMIC_GLOB unless an HCA truly provides global atomic ops; not possible without PCIe 3.0 atomic support I think. But as I said, I think the original suggestion: > > Hence, I think it would be cleaner if a new capability, > > masked_atomic_cap, were introduced, using the original definitions > > (NONE, HCA, GLOB). makes sense, ie create a new props->masked_atomic_cap and set it to NONE, HCA or GLOB as appropriate (ie NONE for everyone except mlx4, and HCA for mlx4). -- Roland Dreier <[email protected]> || For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/index.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
