I don't understand why mlx4_port1 and mlx4_port2 have world write permissions on your system. I can't see this from the sources nor from installing ofed-1.5.1 on my system. I agree though that the permissions for port_trigger and clear_diag should be changed. We'll push a fix to OFED 1.5.2.
On Sun, Jun 6, 2010 at 7:08 PM, Sumeet Lahorani <[email protected]> wrote: > > Thanks. I realized that my earlier find command didn't capture all the files > I was looking for. After your patch, the following still need to be > addressed (all are mlx4 files) > > # find /sys -type f -perm -222 > /sys/class/infiniband/mlx4_0/diag_counters/clear_diag > /sys/devices/pci0000:00/0000:00:04.0/0000:13:00.0/port_trigger > /sys/devices/pci0000:00/0000:00:04.0/0000:13:00.0/mlx4_port2 > /sys/devices/pci0000:00/0000:00:04.0/0000:13:00.0/mlx4_port1 > > - Sumeet > > Or Gerlitz wrote: >> >> Sumeet Lahorani wrote: >> >>> >>> I see the following files created under /sys which are world writeable >>> /sys/class/net/ib0/delete_child >>> /sys/class/net/ib0/create_child >>> At least the create_child & delete_child files appear to be dangerous to >>> leave as world writeable because they result in resources allocations. >>> >> >> Yes, this looks bad. The below patch fixes that, I tested it on 2.6.35-rc1 >> >> [PATCH] make ipoib child entries non-world writable >> >> Sumeet Lahorani <[email protected]> reported that the ipoib child >> entries are world writable, fix them to be root only writable >> >> Signed-off-by: Or Gerlitz <[email protected]> >> >> diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c >> b/drivers/infiniband/ulp/ipoib/ipoib_main.c >> index df3eb8c..b4b2257 100644 >> --- a/drivers/infiniband/ulp/ipoib/ipoib_main.c >> +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c >> @@ -1163,7 +1163,7 @@ static ssize_t create_child(struct device *dev, >> return ret ? ret : count; >> } >> -static DEVICE_ATTR(create_child, S_IWUGO, NULL, create_child); >> +static DEVICE_ATTR(create_child, S_IWUSR, NULL, create_child); >> static ssize_t delete_child(struct device *dev, >> struct device_attribute *attr, >> @@ -1183,7 +1183,7 @@ static ssize_t delete_child(struct device *dev, >> return ret ? ret : count; >> } >> -static DEVICE_ATTR(delete_child, S_IWUGO, NULL, delete_child); >> +static DEVICE_ATTR(delete_child, S_IWUSR, NULL, delete_child); >> int ipoib_add_pkey_attr(struct net_device *dev) >> { >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
