> Is this something that it might be better to expose via ethtool in the > firmware-version field? (You can have a string with multiple versions > of different components there, see eg get_drvinfo() in > drivers/net/cxgb3/cxgb3_main.c)
The main purpose of the patch is to read the eeprom version number and save it off for later use. We will be using that field programmatically in a later patch. We can certainly expose it via ethtool but I would prefer a separate eeprom-version field instead of overloading firmware-version. > As far as I can see, in the current patch, you have eeprom_version as a > pure write-only field. So instead of dumping to the kernel log, where > it might get lost and is in any case hard to find, make it easier to > read out when someone needs it. I typically grep for "iw_nes" when looking for nes prints. It is convenient to have version numbers printed instead of asking someone to explicitly run another command. If you feel strongly about it I can certainly take the prints out. Chien -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
