Jack Morgerstein wrote: > Actually, that feedback was from me :). Oops. Well, that explains why Jason was confused. Sorry Jason.
> Actually, you will still need the install-script setting. If you have > several HCA's of the same type installed on a single host, they will all get > the same node description. > If you wish to differentiate between the different HCA's (which openibd > does), you will still need the install script. > Finally, I'm not convinced that changing the default behavior (to have > utsname: <fw burned description>) is necessary. I think it is redundant, since the sysfs-interface is always available (which can make use of the "@" improvement). Jack, While I agree the start up script plus this patch provides better results than this patch alone it's important to remember this patch is going into the upstream kernel, not OFED, and the openibd script is not part of the upstream kernel. Thus, I felt it was important that this new capability be useful as-is, rather than having no effect without additional code. My intent at this point is to get this patch into the upstream kernel and for the similar patch to be accepted by EWG for 1.5.2 along with an additional EWG-only patch to change the openibd script. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
