On Mon, 2010-08-02 at 17:32 +0200, Bart Van Assche wrote:
> Makes sure that the SCSI mid-layer never tries to queue more than
> (SRP request limit) - 1 SCSI commands. Improves performance for targets whose
> request limit is less than or equal to SRP_SQ_REQ_SIZE (63) by reducing the
> number of BUSY responses.

This is a better commit message, but why is it important to be less than
SRP_REQ_SQ_SIZE or (SRP request limit) - 1 commands?

You and I know that it is because we reserve one credit for sending task
management requests, but will future readers?

On that topic, I wonder if we should have a comment there, since we'll
otherwise have a magic number.

Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to