On Mon, Aug 2, 2010 at 11:44 PM, David Dillow <[email protected]> wrote: > On Mon, 2010-08-02 at 17:32 +0200, Bart Van Assche wrote: > [ ... ] > > There seems to be an accounting change from using tx_head/tx_tail to > using tx_req and tx_rsp. I'm not sure that really makes sense -- > splitting that into its own patch would allow for an easier review and > may make it obvious if it is the right thing to do.
As I wrote in [PATCH 0/4], both initator-to-target requests and initiator-to-target responses are now allocated from the same send queue. Since tx_head - tx_tail is now the sum of the number of requests and the number of responses allocated on the send queue, new variables had to be introduced in order to count how many requests and how many responses had been allocated on the send queue. > SRP_AER_REQ isn't handled, and it wouldn't be much to add it. That would > improve our standards compatibility. The message "Unhandled SRP opcode" is printed for SRP_AER_REQ information units. Support for SRP_AER_REQ can still be added in a follow-up patch. Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
