On Sun, 2010-08-22 at 18:56 +0200, Bart Van Assche wrote:
> @@ -989,19 +989,19 @@ static void srp_send_completion(struct ib_cq *cq, void
> *target_ptr)
> static struct srp_iu *__srp_get_tx_iu(struct srp_target_port *target,
> enum srp_request_type req_type)
> {
> - s32 min = (req_type == SRP_REQ_TASK_MGMT) ? 1 : 2;
> + s32 rsv = (req_type == SRP_REQ_TASK_MGMT) ? 0 : SRP_TSK_MGMT_SQ_SIZE;
> - if (target->req_lim < min) {
> + if (target->req_lim <= rsv) {
> ++target->zero_req_lim;
I'm still not sure these two changes make the intent of the code any
clearer, especially the "less than or equal to the reserved credits".
However, if Roland is OK with it, then
Acked-by: David Dillow <[email protected]>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
