On Thu, 26 Aug 2010, Roland Dreier wrote: > also it's not clear to me why it's OK to do this test of the DGID if the > packet didn't have a GRH -- presumably we are just looking at random > uninitialized memory so we might incorrectly say some packets are > multicast if that byte happens to be 0xff. (or does that not matter? > if so why can't we just always make everything PACKET_MULTICAST?)
We will do an skb_pull to skip over the GRH next? The IP layer checks PACKET_HOST etc in various places so we may risk breakage in odd places like what already occurred here. It would be good to also have support for PACKET_BROADCAST but that would require a full MGID comparison. > It seems the check should be something like > > if ((wc->wc_flags & IB_WC_GRH) && > IN6_IS_ADDR_MULTICAST(((struct ipv6hdr *) skb->data)->daddr)) Hmmm... More IPV6 stuff slipping in. > We probably want to run this addition past netdev. Ok. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
