On Mon, Sep 6, 2010 at 12:43 PM, Sasha Khapyorsky <[email protected]> wrote: > Hi Yevgeny, > > On 12:07 Sun 05 Sep , Yevgeny Kliteynik wrote: >> >> There's a hack in the SM to deal with TopSpin's non-compliant >> join compmask for IPoIB v4 multicast group ff12:401b:<pkey>::1 >> The group is pre-defined and maintained as a well-known multicast >> group. >> >> opensm/osm_prtn.c: >> >> 232 /* workaround for TS */ >> 233 /* FIXME: remove this upon TS fixes */ >> 234 mc_rec.mgid = osm_ts_ipoib_mgid; >> 235 memcpy(&mc_rec.mgid.raw[4], &pkey, sizeof(pkey)); >> 236 /* Scope in MCMemberRecord (if present) needs to be >> consistent with MGID */ >> 237 mc_rec.scope_state = ib_member_set_scope_state(scope, >> IB_MC_REC_STATE_FULL_MEMBER); >> 238 ib_mgid_set_scope(&mc_rec.mgid, scope); >> 239 >> 240 status = osm_mcmr_rcv_find_or_create_new_mgrp(p_sa, >> comp_mask, &mc_rec, >> 241 &p_mgrp); >> 242 if (p_mgrp) { >> 243 p_mgrp->well_known = TRUE; >> 244 if (!p->mgrp) >> 245 p->mgrp = p_mgrp; >> 246 } >> >> As far as I can tell, this was added before git history. >> Any idea if it's still needed? > > I don't know, just remember that we have asked about this during > partition manager development (somewhere in 2006), and have got an > answer like "it is probably needed". > > Personally I've never seen this used. Maybe Hal may remember more.
It's been carried forward just in case anyone was still running the old TS stack. It's always hard to determine the negative (when no one is using it any longer) (with the latest OpenSM) but it may be high time to deprecate this. Is anyone still using the old TS stack ? If so, is it used with OpenSM ? Maybe Roland has insight into whether the old TS stack might be being used with (the latest) OpenSM. -- Hal > > Sasha > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
