On Tue, Sep 7, 2010 at 11:13 AM, Yevgeny Kliteynik <[email protected]> wrote: > Content of p_query_req_copy is used in the function, > so no point checking if it's NULL before the free(). > > Signed-off-by: Yevgeny Kliteynik <[email protected]> > --- > opensm/libvendor/osm_vendor_ibumad_sa.c | 3 +--
Same change could be done for osm_vendor_mlx_sa.c too. -- Hal > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/opensm/libvendor/osm_vendor_ibumad_sa.c > b/opensm/libvendor/osm_vendor_ibumad_sa.c > index 75bc303..1fdcc47 100644 > --- a/opensm/libvendor/osm_vendor_ibumad_sa.c > +++ b/opensm/libvendor/osm_vendor_ibumad_sa.c > @@ -199,8 +199,7 @@ static void __osmv_sa_mad_err_cb(IN void *bind_context, > IN osm_madw_t * p_madw) > if ((p_query_req_copy->flags & OSM_SA_FLAGS_SYNC) == OSM_SA_FLAGS_SYNC) > cl_event_signal(&p_bind->sync_event); > > - if (p_query_req_copy) > - free(p_query_req_copy); > + free(p_query_req_copy); > OSM_LOG_EXIT(p_bind->p_log); > } > > -- > 1.6.2.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
