On Mon, Oct 11, 2010 at 09:13:05PM -0700, Roland Dreier wrote:
> Hi everyone,
> 
> I think I've finally gotten my revision of ummunotify to live within
> userspace verbs into a reasonable state.  I've done no testing beyond
> compiling it and reading over the code -- in fact, I haven't even
> implemented the corresponding support in libibverbs -- but I wanted to
> get this out so that people can take a look.
> 
> Given that we are probably no more than a week away from the 2.6.37
> merge window, I don't think this is appropriate for 2.6.37, but I
> definitely plan to get this into 2.6.38 unless there is some big problem
> I don't see right now.
> 
> As usual, all comments and criticisms welcome!

I made a review and overall it looks good. One comment though. Could
we add an option to ib_uverbs_dereg_mr_common() to deregister all
regions for which notifications have been received? This could relieve
anyone who does not wish to read the notifications from the
notifications channel but instead have it done automatically.
> 
>  
> +struct ib_uverbs_mmu_notify_event_desc {
> +     __u64 cq_handle;
I assume this is going to be mr_handle.
> +};
> +
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to