On Tue, Oct 19, 2010 at 11:28 AM, Hefty, Sean <[email protected]> wrote: >> > but is there a strong reason why ib_types.h can't be moved from >> opensm/include/iba to libibumad/include/infiniband? >> >> Why does this need to be moved ? > > The dependency should be on libibumad, not opensm. libibumad is pretty much > useless without these definitions. Why wouldn't you move them?
Off the top of my head, OpenSM is layered on top of libibumad but doesn't need/use libibmad. I think that was the main reason although that could be changed if ib_types.h were to be moved. I'm not sure what other reasons came up in the previous discussions. > >> There already are diags including ib_types.h (saquery for one). > > Yes, but we're either stuck with everything that needs ib_types.h to be part > of the management.git tree, or the app needs to depend on opensm. Currently, > ibacm duplicates definitions because they aren't available anywhere else. I agree ib_types.h is more generic than opensm. Moving to libibmad and making opensm depend on this is probably better than all the duplication. There have been viewpoints that libibumad and libibmad shouldn't be separate (as they are small) but they were never combined into a single library. -- Hal -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
