On Mon, Oct 18, 2010 at 3:10 PM, David Dillow <[email protected]> wrote:
>
> [ ... ]
> While looking at this, I noticed that we didn't do any syncs in
> srp_send_tsk_mgmt(), so I've pushed this patch for now. We can remove
> the *_sync_for_cpu() calls later if it turns out we really don't need
> them.
> [ ... ]
> +       ib_dma_sync_single_for_cpu(dev, iu->dma, sizeof *tsk_mgmt,
> +                                  DMA_TO_DEVICE);

Hello Dave,

Sorry for the late comment, but I just noticed that the above code
performs a partial buffer synchronization. If I remember correctly,
the DMA API doesn't allow this and the "size" argument must match the
size argument passed to the corresponding ib_dma_map_single() call,
that is, target->max_ti_iu_len ?

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to