On Sun, Oct 24, 2010 at 6:22 PM, Roland Dreier <[email protected]> wrote: > > No you did not. It was there already but we never noticed before > > Yossi's patch. > > But AFAICT Yossi's patch (5eb620c8) went into 2.6.22 about 2.5 years > ago... wasn't that already there way before the IBoE stuff started? >
I see... I think the reason it started failing comes from this portion of patch 8: + mlx4_ib_port_link_layer(ibdev, port) == IB_LINK_LAYER_INFINIBAND ? + ib_link_query_port(ibdev, port, props, out_mad) : + eth_link_query_port(ibdev, port, props, out_mad); I discarded the value returned and you added it as it should be. So the fix is valid anyway, but the changelog has to be changed, probably to something like: eth_link_query_port() returns error if a netdevice was not yet associated with the IBoE port. This is not required since we already initialize the link as down. Failure to do so can cause mlx4_ib loading to fail. Fix this by always returning success. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
