> I guess what I'm objecting to is hard coding mlx4. > I was trying to think of a way that would allow other HCAs > to support the block loopback option in the future. > It looks like ipoib sets IB_QP_CREATE_BLOCK_MULTICAST_LOOPBACK > for kernel QPs but this isn't defined in libibverbs yet.
If there's a per QP flag for kernel users, I don't understand why it was automatically disabled HCA wide. > It seems reasonable to add that feature some time in the future > and change ibacm to use it. > > In the mean time, I guess I don't see an alternative to your patch. The best alternative I can think of is to add a 'loopback' configuration option to acm. The benefits of being able to block loopback multicast traffic may be greater than anything gained by not doing so. I'll make this change and just use a default value that does not require loopback multicast. At some point, when libibverbs exposes this capability, acm can take advantage of it. - Sean -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
