On Mon, 2010-12-27 at 16:01 +0100, Bart Van Assche wrote: > On Thu, Dec 23, 2010 at 10:31 PM, David Dillow <[email protected]> wrote: > > > > We can only have one task management comment outstanding, so move the > > completion and status to the target port. This allows us to handle > > resets of a LUN without a corresponding request having been sent. > > Meanwhile, we don't need to play games with host_scribble, just use it > > as the pointer it is. > > > > This fixes a crash when we issue a bus reset using sg_reset. > > > > Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=13893 > > Signed-off-by: David Dillow <[email protected]> > > You can add here "Reported-by: Bart Van Assche <[email protected]>" > if you want.
Good idea, will do. > > > > - SRP_TAG_TSK_MGMT = 1 << (SRP_RQ_SHIFT + 1), > > + SRP_TAG_NO_REQ = ~0UL, > > + SRP_TAG_TSK_MGMT = 1UL << 31, > > According to ANSI C, enumeration types have the same size as an int, > so the above two declarations will assign a long to an int. The types > long and int do not need to have the same size, so I suggest to leave > out the capital L in the above. Yeah, wil ldo. > > And checkpatch says this: > > WARNING: please, no space before tabs > #114: FILE: drivers/infiniband/ulp/srp/ib_srp.c:1462: Heh, usually I catch those... oh well. Will fix. Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
