On Tue, Jan 11, 2011 at 6:43 PM, Tejun Heo <[email protected]> wrote:
> Hello,
>
> On Tue, Jan 11, 2011 at 06:29:52PM +0100, Bart Van Assche wrote:
>> On Tue, Jan 11, 2011 at 2:45 AM, Roland Dreier <[email protected]> wrote:
>> >
>> >  >    git://git.kernel.org/pub/scm/linux/kernel/git/dad/srp-initiator.git 
>> > srp-lock-scaling
>> >
>> > Thanks, pulled.
>> >
>> > Will try to merge Tejun's work queue patch shortly.
>>
>> Maybe it's a good idea to add a comment above the declaration of the
>> global variable "extern struct workqueue_struct *ib_wq;" that explains
>> that that variable has been added during the work queue conversion and
>> that the preferred approach for new code is to define a new work queue
>> instead of using ib_wq ?
>
> But why is defining more workqueues preferred?  Unless there's a
> specific need, using what's already there (system or ib_wq) should be
> preferable.

Sorry, but I just noticed that I had missed the part of the discussion
that happened on the LKML and where linux-rdma was not CC-ed:
https://lkml.org/lkml/2010/12/16/244. I think that thread contains
valuable information.

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to