I saw that, but wanted to replicate the patch as we authored it internally.
I agree that 32 bit jiffies (given the 500ms timeout), would be sufficient and that the time_is_before_jiffies() macro would be a better solution. I will work with Mitko to get a revision with your suggestions. Mike -----Original Message----- From: Roland Dreier [mailto:[email protected]] Sent: Monday, April 11, 2011 4:25 PM To: Mike Marciniszyn Cc: [email protected] Subject: Re: [PATCH] IB/qib: Prevent driver hang with unprogrammed boards On Mon, Apr 11, 2011 at 6:45 AM, Mike Marciniszyn <[email protected]> wrote: > - !time_after64(tstart, tstart + msecs_to_jiffies(500))) { > + !time_after64(get_jiffies_64(), > + tstart + msecs_to_jiffies(500))) { By the way, is there any need to use 64-bit jiffies stuff here? Couldn't this be more cleanly written with just time_is_before_jiffies()? This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
