> -----Original Message----- > From: Roland Dreier [mailto:[email protected]] > Sent: Monday, May 09, 2011 10:35 PM > To: Nir Muchtar > Cc: [email protected]; [email protected] > Subject: Re: [PATCH V4 1/6] IB Netlink Infrastructure > > > +int ibnl_add_client(int index, int nops, > > + const struct ibnl_client_cbs cb_table[]) > > +{ > > + struct ibnl_client *cur; > > + struct ibnl_client *nl_client = kmalloc(sizeof *nl_client, > GFP_ATOMIC); > > + > > + if (!nl_client) > > + return -ENOMEM; > > + nl_client->index = index; > > + nl_client->nops = nops; > > + nl_client->cb_table = cb_table; > > + mutex_lock(&ibnl_mutex); > > quick question: why is GFP_ATOMIC used here? It seems that since the > function later does mutex_lock(), there can't be any problem with > sleeping. > > - R.
No reason. Typo...Thanks. I'll fix and resend. Nir -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
