On May 22, 2011, at 9:05 PM, Roland Dreier wrote:

>> @@ -2738,6 +2745,7 @@ static void init_mad_qp(struct
> ib_mad_port_private *port_priv,
>>      spin_lock_init(&qp_info->snoop_lock);
>>      qp_info->snoop_table = NULL;
>>      qp_info->snoop_table_size = 0;
>> +    qp_info->qp = NULL;
>>      atomic_set(&qp_info->snoop_count, 0);
>> }
> 
> This bit isn't needed, is it?  qp_info is in memory allocated with kzalloc.
> (We could get rid of the other = 0 / = NULL lines too)
> 

Yes, sorry, revised attached,
Ira


Attachment: 0001-Return-EPROTONOSUPPORT-when-an-RDMA-device-lacks-the.patch
Description: Binary data

Reply via email to