On 7/14/2011 2:34 PM, Hefty, Sean wrote:
>> -    IB_ATTR_LAST
>> +    IB_ATTR_LAST,
>> +
>> +    IB_ATTR_MLNX_EXT_PORT_INFO = 0xff90,
>>  };
> 
> Seems kind of odd to have something come after 'last'..

I'm not sure why IB_ATTR_LAST is even there (similarly for
IB_SA_ATTR_LAST); maybe a historical vestige at this point but due to
backward compatibility (who knows if it's used) should remain.

It's a poor name given vendor SM attribute IDs.

I didn't think it was safe to have IB_ATTR_LAST increase from 0x21 to
0xff91 because of this so I thought it best to add it as I did and treat
this new attribute ID as an exception if needed which it isn't currently.

-- Hal
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to